Fix CloudVolume* STI types on older CinderManagers #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older Openstack CinderManagers didn't use the subclassed Openstack::StorageManager::CinderManager but rather the base CinderManager. This caused the previous data migration to miss these records because it was querying on active Openstack CinderManagers.
|
Checked commit agrare@5924e11 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
worked for me, thanks! 👍 |
|
ManageIQ/manageiq-providers-openstack#242 changed the class that was created to use the subclassed openstack cinder_manager, however it didn't change the association's class_name [ref] and I don't see a data migration associated with it which is why newly created Cinder managers are of the openstack subclass but what @himdel had in his database was the older type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older
OpenstackCinderManagersdidn't use the subclassedManageIQ::Providers::Openstack::StorageManager::CinderManagerbut rather the baseManageIQ::Providers::StorageManager::CinderManager. This caused the previous data migration to miss these records because it was querying on activeOpenstackCinderManagers.This led to:
[ActiveRecord::SubclassNotFound] The single-table inheritance mechanism failed to locate the subclass: 'ManageIQ::Providers::Openstack::CloudManager::CloudVolumeSnapshot'. This error is raised because the column 'type' is reserved for storing the class in case of inheritance. Please rename this column if you didn't intend it to be used for storing the inheritance class or overwrite CloudVolumeSnapshot.inheritance_column to use another column for that information.Follow-up to #532